feat: set --target for dump command#4682
Merged
MichaelEischer merged 2 commits intorestic:masterfrom Feb 5, 2024
Merged
Conversation
MichaelEischer
requested changes
Feb 4, 2024
Member
MichaelEischer
left a comment
There was a problem hiding this comment.
Thanks for working on this feature! I only have two small comments, see below.
konidev20
commented
Feb 4, 2024
MichaelEischer
requested changes
Feb 4, 2024
15a6652 to
f5ffa40
Compare
MichaelEischer
approved these changes
Feb 5, 2024
Member
MichaelEischer
left a comment
There was a problem hiding this comment.
LGTM. Thanks!
I've rebased and squashed the commits and made a few further small tweaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Was the change previously discussed in an issue or on the forum?
Closes #4678
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.