Skip to content

Downgrade klauspost/compress to fix data corruption at max. compression#4679

Merged
MichaelEischer merged 2 commits intorestic:masterfrom
MichaelEischer:workaround-compression-bug
Feb 4, 2024
Merged

Downgrade klauspost/compress to fix data corruption at max. compression#4679
MichaelEischer merged 2 commits intorestic:masterfrom
MichaelEischer:workaround-compression-bug

Conversation

@MichaelEischer
Copy link
Copy Markdown
Member

What does this PR change? What problem does it solve?

Switch back to the version of the compress library used by restic 0.16.2.

Was the change previously discussed in an issue or on the forum?

Temporary workaround for #4677 .

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

@MichaelEischer MichaelEischer marked this pull request as ready for review February 2, 2024 19:12
@MichaelEischer MichaelEischer force-pushed the workaround-compression-bug branch from 05dcf9c to 8bf70da Compare February 4, 2024 10:40
Copy link
Copy Markdown
Contributor

@rawtaz rawtaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor change, otherwise good!

@MichaelEischer MichaelEischer force-pushed the workaround-compression-bug branch from 8bf70da to 219d8e3 Compare February 4, 2024 17:11
Copy link
Copy Markdown
Contributor

@rawtaz rawtaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelEischer MichaelEischer added this pull request to the merge queue Feb 4, 2024
Merged via the queue into restic:master with commit effe76a Feb 4, 2024
@MichaelEischer MichaelEischer deleted the workaround-compression-bug branch February 4, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants