Properly report the ID of newly added keys#4657
Merged
MichaelEischer merged 1 commit intorestic:masterfrom Jan 31, 2024
Merged
Conversation
22a64db to
cd098d4
Compare
MichaelEischer
requested changes
Jan 26, 2024
Member
MichaelEischer
left a comment
There was a problem hiding this comment.
The ideal solution would be to add JSON support to key add. But I agree that the current output is not useful. So I'm fine with changing it, I just just have a few small remarks as commented below.
Other commands like key list and key remove show the key's ID. Showing the ID here lets users easily reuse the ID as a key hint for subsequent commands. In particular, a key hint is needed when the repository has many keys - otherwise opening the repository may fail with "Fatal: maximum number of keys reached" even when a proper password is provided. Fixes restic#4656
cd098d4 to
8fbe328
Compare
Contributor
Author
|
Updates following your suggestions, thanks. |
Member
That would be great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Other commands like key list and key remove show the key's ID.
Showing the ID here lets users easily reuse the ID as a key hint for subsequent commands. In particular, a key hint is needed when the repository has many keys - otherwise opening the repository may fail with "Fatal: maximum number of keys reached" even when a proper password is provided.
Was the change previously discussed in an issue or on the forum?
Fixes #4656
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.