Rewrite metadata#4573
Merged
MichaelEischer merged 11 commits intomasterfrom Dec 24, 2023
unknown repository
Merged
Conversation
22983a4 to
6b429b9
Compare
Contributor
|
Funnily I thought about this exact use case the other day…! |
Adds
* snapshotMetadataArgs, which holds the new metadata as strings parsed from
the command line
* snapshotMetadata, which holds the new metadata converted to the
correct types
7ff5c1b to
405bfc5
Compare
MichaelEischer
approved these changes
Dec 24, 2023
Member
MichaelEischer
left a comment
There was a problem hiding this comment.
LGTM. I've added a few cleanup commits and rebased the PR.
Pass nil instead of metadata to existing tests
8098cfc to
01b3373
Compare
minosimo
reviewed
Jan 31, 2024
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
This PR allows to rewrite the host and time metadata of a snapshot.
Was the change previously discussed in an issue or on the forum?
Related to #2654
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.