backend, termstatus: fix ioctl calls for 64-bit big-endian platforms#4339
Merged
Conversation
Fixes restic#4223. Verified with QEMU on linux/amd64.
This function casts its argument to int32 before passing it to the system call, so that big-endian CPUs read the lower rather than the upper 32 bits of the pid. This also gets rid of the last import of "unsafe" in the Unix build. I changed syscall to x/sys/unix while I was at it, to remove one more import line. The constants and types there are aliases for their syscall counterparts.
MichaelEischer
approved these changes
May 26, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Changes the way we call ioctl to get and set terminal info. The old code didn't work on some 64-bit big-endian platforms, notably linux/s390x.
See commit messages for details. This code already has tests.
Was the change previously discussed in an issue or on the forum?
Fixes #4223.
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.