Remove usage of tomb package#3785
Merged
MichaelEischer merged 3 commits intorestic:masterfrom Jun 19, 2022
Merged
Conversation
greatroar
approved these changes
Jun 5, 2022
Contributor
|
Nice work. I had two serious tries at this myself, but never ended up with working code that I could submit as a PR. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
The tomb package is only used within the backup command / the archiver. All other code parts are using
errgroup.Groupinstead. This PR replaces all tomb usages with errgroup to cleanup the code.tomb offers the
t.Kill(nil)method which has no direct equivalence in errgroup. As replacement is is possible to either add explicit methods to shut down tasks as is now done in the archiver.Blob/File/TreeSaver. Or it can be emulated using a combination of errgroup andcontext.WithCancel:Was the change previously discussed in an issue or on the forum?
No.
Checklist
[ ] I have added documentation for relevant changes (in the manual).[ ] There's a new file inchangelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.