Let check warn about legacy variants of the repo format version 1#3730
Merged
MichaelEischer merged 6 commits intorestic:masterfrom Jul 23, 2022
Merged
Let check warn about legacy variants of the repo format version 1#3730MichaelEischer merged 6 commits intorestic:masterfrom
check warn about legacy variants of the repo format version 1#3730MichaelEischer merged 6 commits intorestic:masterfrom
Conversation
77c054c to
00478e1
Compare
13 tasks
604dae5 to
7c9cfa3
Compare
Unused blobs are not a problem but rather expected to exist now that prune by default does not remove every unused blob. However, the option has caused questions from users whether a repository is damaged or not, so just remove that option. Note that the remaining code is left intact as it is still useful for our test cases.
7c9cfa3 to
5a6f2f9
Compare
Member
Author
|
I've rebased the PR, added slightly reworded the warning printed for mixed packs and added a changelog entry. Besides that the PR is essentially unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
The legacy S3 repository layout and mixed packs are not used for new repositories since quite some time. Especially the mixed packs are a problem as they will drastically increase the cache size and slow down everything. This PR let's check complain about these legacy variants of the repository format version 1.
The mixed packs warning leads to the somewhat ugly situation that the test data used for the check is also affected by that warning. I've decided to simply filter these warnings, as that way the test implicitly tests that we are still able to read old repositories.
The
--check-unusedoption is also deprecated as it is now rather useless sincepruneno longer removes all unused blob by default. This removes the option from the CLI, but keeps it for internal test case usage.Was the change previously discussed in an issue or on the forum?
No. I've only complained about
--check-unusedbeing confusing somewhere in the forum ;-) .Fixes #3295
Checklist
[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.