Conversation
--read-data-from--read-data-from
1a36f86 to
64a9b14
Compare
|
Added some parameter checks, docu and a changelog file. |
| Restic check used to check either all packfiles or a subset that is chosen | ||
| either in a deterministic or random way but did not allow to specify the pack | ||
| files to check directly. | ||
| This feature is now added. It allows to fine-tune the checking process or support | ||
| troubleshooting in case of corrupted repositories. |
There was a problem hiding this comment.
Suggestion:
Restic check used to check either 1) all packfiles or 2) a subset of the packfiles.
The subset was chosen either a) deterministically or b) randomly.
This feature adds the possibility to provide an explicit list of pack files, thereby making it possible to fine-tune the checking process when, for example, troubleshooting in case of corrupted repositories.
|
This feature would be quite useful. Is this PR on track to get merged? |
1 similar comment
|
This feature would be quite useful. Is this PR on track to get merged? |
|
This PR doesn't seem to apply cleanly anymore, but it was trivial to fix the conflicts in restic 0.15.2 (I haven't tried 0.16.0 or even the master branch). I also tested the PR by checking one blob which I suspected was corrupted and AFAICT it worked fine. I hope the PR gets merged as this functionality seems to be extremely useful to efficiently check whether some blobs have been corrupted or not (e.g. after restic gives an error message). |
What does this PR change? What problem does it solve?
Adds an option to
checkto read the pack files to be checked from a file.This is handy to control which files are actually read by
check. Also allows to only check a few pack files in troubleshooting cases without needing to download all pack files (which might be very expensive and time-consuming)Was the change discussed in an issue or in the forum before?
see #3202
In the forum there was a discussion (don't find it right now) where a user wanted to troubleshoot some corrupt pack file but rejected to run a full
check --read-dataas this would cost too much...Checklist
changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits