Defer channel closing outside repository.RunWorkers#3022
Merged
MichaelEischer merged 1 commit intorestic:masterfrom Oct 14, 2020
Merged
Defer channel closing outside repository.RunWorkers#3022MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer merged 1 commit intorestic:masterfrom
Conversation
Contributor
Author
|
I just noticed that this will likely give a merge conflict with #3006. |
MichaelEischer
approved these changes
Oct 14, 2020
Member
MichaelEischer
left a comment
There was a problem hiding this comment.
LGTM. We've finally managed to remove almost all code from RunWorkers ^^
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
This is a tiny refactor that replaces a callback by a defer'd call. It's mostly stylistic, but it might make some stack traces shorter: when a worker goroutine panics, other goroutines have a chance of exiting, so their stack no longer needs to be reported
Was the change discussed in an issue or in the forum before?
Can be considered a follow-up to #2560.
Checklist
gofmton the code in all commits