Skip fopen for file change check to avoid network penalty#2970
Merged
MichaelEischer merged 1 commit intorestic:masterfrom Oct 9, 2020
Merged
Skip fopen for file change check to avoid network penalty#2970MichaelEischer merged 1 commit intorestic:masterfrom
MichaelEischer merged 1 commit intorestic:masterfrom
Conversation
greatroar
reviewed
Oct 2, 2020
Member
|
Please squash the commits and add a changelog entry (see changelog/TEMPLATE for the template). |
Contributor
Author
|
@MichaelEischer PR is ready. |
Contributor
Author
|
@MichaelEischer I've changed the wording with your suggestions, is much clear now. |
Contributor
Author
|
@MichaelEischer thanks to you for such an amazing tool!
|
This was referenced Dec 31, 2020
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2969
This PR reduces drastically the time to perform a backup on top of a network filesystem. It does so by reducing the number of
fopencalls by checking for file changes before.On a 1 million files tree, the time to backup is reduced from 60 minutes to 22 minutes. Network filesystems are sensitive to
fopenoperations, as it often requires to open the file in the data server, while astatoperation does not.Checklist
changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits