prune/rebuild-index: Add warmup possibilities#2881
prune/rebuild-index: Add warmup possibilities#2881aawsome wants to merge 3 commits intorestic:masterfrom
Conversation
|
I rebased to master and added to |
|
The more options there are, the more confusing it is for users. We want to keep the number of options as small as possible. Please try to not introduce new options unless really necessary. Is it really necessary in this case, and if so why can't it be the default behavior instead? |
See #3202. This is only relevant if "data pack files" cannot be accessed immediately. If this is the case, we need to distinguish the "warm-up" run and the real run, where the needed files are accessible (which can be hours later that the warm-up run). Of course, we could decide not to add the |
9795c5a to
4d52cfb
Compare
|
see also rustic-rs/rustic#121 |
What does this PR change? What problem does it solve?
Adds the possibility to access all packs which need a repack during
pruneandrebuild.indexThis allows some cold storages to warm up these packs such that they are all accessable. This warm-up can also be done within a dry run such that the needed packs are available for the next
prunerun.Also the
--jsonoption is now implemented for prune dry-run. This allows to build custom warm-up processes if the pure access to files doesn't do the warmup.This can be easily extended to
restore, see #2796.Was the change discussed in an issue or in the forum before?
The idea comes from #2796.
For cold storage discussions see also #2504
I didn't see a discussion about pruning cold storage, but this PR proved to be very useful for pruning my OVH Cloud Archive repositories.
Checklist
changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits