Add prune integration tests for many edge cases#2844
Add prune integration tests for many edge cases#2844MichaelEischer merged 1 commit intorestic:masterfrom
Conversation
efe0453 to
a18652f
Compare
|
Just realized that the "failing test" (it was a blob existing in the pack file but missing in the index) is in fact cured by "old" prune. So I changed this accordingly here. |
a18652f to
1c80707
Compare
|
rebased after #2674 has been merged. |
MichaelEischer
left a comment
There was a problem hiding this comment.
How did you generate the test data sets? I wonder if there's an easy way to generate those on the fly?
Honestly, by playing a lot around with creating backups, deleting manually single files from the repo, running Also I think that keeping the repos as tar files "hardens" the tests cases in the sense that future code changes will not spoil the test cases. |
1c80707 to
b60368e
Compare
There was a problem hiding this comment.
Also I think that keeping the repos as tar files "hardens" the tests cases in the sense that future code changes will not spoil the test cases.
That will also in parts verify that we don't break repository backwards compatibility.
I'd like to have the edge case tests as subtests to allow selecting a specific one. Besides that the code is ok. (The travis build error will disappear on the next CI run.)
b60368e to
6822a58
Compare
What is the purpose of this change? What does it change?
Add prune integration tests for many edge cases like duplicate blobs, mixed blobs or all types of corrupt repo.
Was the change discussed in an issue or in the forum before?
This is part of #2718 that can be merged independently.
Checklist
changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits