Closed
Conversation
Member
|
Is this used anywhere else except for #2718? If no please just merge it back into that PR. |
Contributor
Author
Member
|
Let's just include this PR as a separate commit in #2718 and if you need the changes in #2543 then also add the commit there. It's much easier to judge whether the changes are useful, if there's a bit of context. A simple rebase would then be enough to remove the commit again once it was merged via a different PR. |
Contributor
Author
|
All right, I close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change? What does it change?
Make some pack parameters public that are needed, e.g. by #2718
Was the change discussed in an issue or in the forum before?
see #2718
Checklist
changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits