Reimplement LookupBlobSize without loop + allocation#2788
Closed
greatroar wants to merge 4 commits intorestic:masterfrom
Closed
Reimplement LookupBlobSize without loop + allocation#2788greatroar wants to merge 4 commits intorestic:masterfrom
greatroar wants to merge 4 commits intorestic:masterfrom
Conversation
f933125 to
6bf735e
Compare
b4e3756 to
801cf84
Compare
7 tasks
Contributor
Author
|
Reviewers: please check #2789 first. |
8 tasks
Member
|
Closing this as the change was merged as part of #2812. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change? What does it change?
Repository.LookupBlobSize calls Index.LookupSize, which calls Index.Lookup. That method constructs a list of all known locations for blob in a newly allocated slice, using an implicit loop in the copy function. The slice is then ignored except for the first element.
This PR changes LookupSize to just do its own lookup and return the first hit. This should speed up restic mount. The restorer can now also use LookupBlobSize instead of its own reimplementation of the size lookup, decoupling it from crypto.
Was the change discussed in an issue or in the forum before?
This should fix any performance regression caused by #2787.
Checklist
changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits