Prevent double index lookup in restic cat#2701
Closed
greatroar wants to merge 1 commit intorestic:masterfrom
Closed
Prevent double index lookup in restic cat#2701greatroar wants to merge 1 commit intorestic:masterfrom
greatroar wants to merge 1 commit intorestic:masterfrom
Conversation
6 tasks
cc3d8ea to
e7d2e52
Compare
e7d2e52 to
bd76744
Compare
5 tasks
7 tasks
Member
|
Closing this as it's replaced by #2789 and, in hindsight, the duplicate index lookup inside |
Contributor
Author
|
Fair enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change? What does it change?
restic cat has to do two Lookups to find a blob. This PR introduces an error type for LoadBlob to signal that a blob is not found in the index, so that cat can check for this.
Was the change discussed in an issue or in the forum before?
In a comment on #2640.
Checklist
changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits