Merged
Conversation
This was referenced Dec 15, 2019
Closed
greatroar
reviewed
Feb 26, 2020
Fix saving/loading config file: Always set ID to a zero ID.
548c555 to
d3c59d1
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change? What does it change?
access to config file from repository was inconsistent and therefore unsafe for new possible backends. This is fixed in this PR.
See #2498.
Was the change discussed in an issue or in the forum before?
closes #2498
Checklist
changelog/unreleased/that describes the changes for our users (template here) - dont't think this is necessary for this minor change.gofmton the code in all commits