Skip to content

Add --ignore-inode option to backup cmd#2205

Merged
fd0 merged 2 commits intorestic:masterfrom
HeikoBornholdt:ignore-inode
Mar 16, 2019
Merged

Add --ignore-inode option to backup cmd#2205
fd0 merged 2 commits intorestic:masterfrom
HeikoBornholdt:ignore-inode

Conversation

@HeikoBornholdt
Copy link
Copy Markdown

@HeikoBornholdt HeikoBornholdt commented Mar 10, 2019

What is the purpose of this change? What does it change?

revised version of #2047

This PR adds --ignore-inode option to backup command, in order to support those filesystems that don't support fixed inodes, typically Fuse, pCloud, etc.

Was the change discussed in an issue or in the forum before?

#1631
#2047

Checklist

  • I have read the Contribution Guidelines
  • I have added tests for all changes in this PR
  • I have added documentation for the changes (in the manual)
  • There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
  • I have run gofmt on the code in all commits
  • All commit messages are formatted in the same style as the other commits in the repo
  • I'm done, this Pull Request is ready for review

@HeikoBornholdt HeikoBornholdt marked this pull request as ready for review March 12, 2019 18:23
Copy link
Copy Markdown
Member

@fd0 fd0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for continuing the work started in #2047!

@fd0 fd0 merged commit d138b38 into restic:master Mar 16, 2019
@goniz
Copy link
Copy Markdown

goniz commented Apr 14, 2019

@fd0 when will this PR make it into an official release?

@fd0
Copy link
Copy Markdown
Member

fd0 commented Apr 15, 2019

When the next version of restic is released. As this is an open source project we don't have a timeline :)

If you want to use it right now, either compile restic yourself from the master branch (which should be pretty stable) or use one of the beta binaries here: https://beta.restic.net/?sort=time&order=asc

@nixzahlen
Copy link
Copy Markdown

When the next version of restic is released. As this is an open source project we don't have a timeline :)

If you want to use it right now, either compile restic yourself from the master branch (which should be pretty stable) or use one of the beta binaries here: https://beta.restic.net/?sort=time&order=asc

C:\Temp\restic>go run -v -mod=vendor build.go
errors
# errors
compile: version "go1.12.2" does not match go tool version "go1.11"
math/bits
internal/cpu
# math/bits
compile: version "go1.12.2" does not match go tool version "go1.11"
# internal/cpu
compile: version "go1.12.2" does not match go tool version "go1.11"
runtime/internal/atomic
runtime/internal/sys
# runtime/internal/atomic
compile: version "go1.12.2" does not match go tool version "go1.11"
# runtime/internal/sys
compile: version "go1.12.2" does not match go tool version "go1.11"
unicode/utf8
internal/race
# unicode/utf8
compile: version "go1.12.2" does not match go tool version "go1.11"
# internal/race
compile: version "go1.12.2" does not match go tool version "go1.11"
sync/atomic
unicode
# sync/atomic
compile: version "go1.12.2" does not match go tool version "go1.11"
internal/syscall/windows/sysdll
# unicode
compile: version "go1.12.2" does not match go tool version "go1.11"
unicode/utf16
# internal/syscall/windows/sysdll
compile: version "go1.12.2" does not match go tool version "go1.11"
# unicode/utf16
compile: version "go1.12.2" does not match go tool version "go1.11"

@fd0
Copy link
Copy Markdown
Member

fd0 commented Apr 22, 2019

@nixzahlen your comment is unproductive and comes across as passive-aggressive. Don't do that, here or anywhere, but especially not here. It wears me and other contributors down and reduces my motivation a lot. In fact, now I'm thinking about what I should write here instead of working on the code.

I assume you are complaining that my statement ("compiled the code yourself") does not work for you. It looks like you have somehow misconfigured your Go environment: this error occurs if the directory the environment variable GOROOT is explicitly configured (check by running go env GOROOT) references a different installation of Go than the one the go executable you run is from. It has nothing to do with restic, as you can easily find out yourself by searching for the error message. Run set GOROOT= (avoid trailing spaces here) before running go. Or use a pre-compiled binary.

So, next time, please spend five to ten minutes looking for the error message yourself, then create a new issue here. Don't comment on old, closed issues or PRs if you can avoid it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants