backup: prevent exclude of backup targets#21797
Merged
MichaelEischer merged 3 commits intoMay 31, 2026
Merged
Conversation
d58168d to
4a9a766
Compare
4a9a766 to
42988d0
Compare
Track backup targets explicitly specified by the user and prevent excluding them. This for example ensures that `restic backup --exclude-if-present .git /home/user/data` backs up the `data` folder even if there is a `.git` folder in `/home/user`. Note that this does not suffice for commands like `restic backup --exclude data /home/user/data` as the exclude pattern will still match every single file within `data`.
42988d0 to
795ad59
Compare
rawtaz
reviewed
May 30, 2026
795ad59 to
7e8f9a9
Compare
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Track backup targets explicitly specified by the user and prevent excluding them. This for example ensures that
restic backup --exclude-if-present .git /home/user/databacks up thedatafolder even if there is a.gitfolder in/home/user.Note that this does not suffice for commands like
restic backup --exclude data /home/user/dataas the exclude pattern will still match every single file withindata.The code is mostly AI written with massive micromanagement to prevent overcomplicated implementations.
Was the change previously discussed in an issue or on the forum?
Fixes #5767
Checklist
changelog/unreleased/that describes the changes for our users (see template).