Skip to content

restic does not detect rclone termination #2381

@shane-kerr

Description

@shane-kerr

Output of restic version

restic 0.9.5 compiled with go1.12.4 on linux/arm

How did you run restic exactly?

GOGC=20 nice -n 19 ionice -c 3 restic -r rclone:jotta:xxx --password-file xxx.passwd backup --one-file-system -v /mnt/xxx

In one case the system had 2 Gbyte of RAM, and the Linux out-of-memory (OOM) killer terminated the rclone process, and in a second case the system had 1 Gbyte of RAM and the OOM killer terminated the rclone process.

In both cases, restic just hung, doing nothing.

What backend/server/service did you use to store the repository?

Jottacloud, but I saw identical behavior using the sftp backend.

Expected behavior

restic should detect that rclone has died and exit with an error.

Actual behavior

restic sat there quietly, doing nothing.

Steps to reproduce the behavior

It seems like you can get similar results just by killing the rclone process by hand.

Do you have any idea what may have caused this?

restic ignoring SIGCHLD and/or pipe file descriptor closes.

Do you have an idea how to solve the issue?

Detect the error and exit.

Did restic help you or made you happy in any way?

restic is awesome. I am nervous to have built all of my backups around it, but so far so good! 😂👍

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions