[RESTEASY-3600] Fix SSE stream failures on session invalidation. #4724
+80
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent SSE broadcast errors when HTTP sessions are invalidated by adding session validation and stream state tracking. This ensures SSE sinks fail gracefully and are properly cleaned up when the underlying session becomes invalid. https://issues.redhat.com/browse/RESTEASY-3600 Signed-off-by: James R. Perkins <jperkins@ibm.com>
3eea7d1 to
4ea9fdf
Compare
Collaborator
|
At this point I can say that the changes seem to fix the problem as it's described in RESTEASY-3600. I can't say that I feel confident that I understand the problem well enough to verify that the the analysis is correct, but if the tests are passing and Volker Godas confirms that their problem goes away, then I think it's worth merging. |
Member
Author
|
Excellent, thank you @ronsigal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent SSE broadcast errors when HTTP sessions are invalidated by adding session validation and stream state tracking. This ensures SSE sinks fail gracefully and are properly cleaned up when the underlying session becomes invalid.
https://issues.redhat.com/browse/RESTEASY-3600
Upstream #4723