[RESTEASY-3632] Deprecate the RESTEasy Netty integration. Some test r… #4682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates the RESTEasy Netty integration modules and refactors related tests to use a new testing framework. The modules are being moved to a separate project and will be removed in the future.
Key changes include:
- Deprecation of all Netty integration classes with
@Deprecated(forRemoval = true, since = "6.2.13.Final") - Comprehensive test refactoring from Netty-based tests to CDI-based tests using a new JUnit extension
- Addition of a new RESTEasy Client Authentication Utility for test requirements
Reviewed Changes
Copilot reviewed 64 out of 64 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| testsuite/integration-tests/pom.xml | Removed resteasy-netty4 dependency |
| server-adapters/resteasy-reactor-netty/ | Added deprecation annotations to all classes and updated test dependencies |
| server-adapters/resteasy-netty4/ | Added deprecation annotations to all classes |
| security/resteasy-crypto/ | Refactored tests from Netty to CDI-based testing |
| resteasy-wadl/ | Migrated test from Netty to CDI framework |
| resteasy-rxjava2/ | Updated tests to use new testing framework |
| resteasy-reactor/ | Refactored tests and updated dependencies |
| resteasy-links/ | Comprehensive test migration and cleanup |
| resteasy-client-utils/ | Added new BasicAuthorizationFilter utility |
| docbook/ | Updated documentation with deprecation notices |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| <artifactId>resteasy-reactor-netty</artifactId> | ||
| <version>{resteasy-version}</version> | ||
| <groupId>dev.resteasy.netty</groupId> | ||
| <artifactId>resteasy-embedded-server-rectory</artifactId> |
There was a problem hiding this comment.
The artifact ID contains a typo. It should be 'resteasy-embedded-server-reactor' instead of 'resteasy-embedded-server-rectory'.
| ---- | ||
| <dependency> | ||
| <groupId>dev.resteasy.netty</groupId> | ||
| <artifactId>resteasy-embedded-server-rectory</artifactId> |
There was a problem hiding this comment.
The artifact ID contains a typo. It should be 'resteasy-embedded-server-reactor' instead of 'resteasy-embedded-server-rectory'.
…efactoring was required so these modules can be removed in the future. These modules have been moved to a new project. There was also a requirement in the test refactoring to include one additional RESTEasy Client Authentication Utility. https://issues.redhat.com/browse/RESTEASY-3632 Signed-off-by: James R. Perkins <jperkins@ibm.com>
412de6c to
e1edb11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…efactoring was required so these modules can be removed in the future. These modules have been moved to a new project.
There was also a requirement in the test refactoring to include one additional RESTEasy Client Authentication Utility.
https://issues.redhat.com/browse/RESTEASY-3632
Upstrea: #4683