[RESTEASY-3591] No SocketConfig is set for Connection Managers in Cli… #4545
+17
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamezp
requested changes
Mar 18, 2025
Member
jamezp
left a comment
There was a problem hiding this comment.
Please note this project uses a maven plugin to format the code. All the should need to be done to format it is compile the code or simply run mvn formatter:format.
...-client/src/main/java/org/jboss/resteasy/client/jaxrs/engines/ClientHttpEngineBuilder43.java
Outdated
Show resolved
Hide resolved
Member
|
We require all contributions to be made under the terms of the ASL 2.0 License: http://www.apache.org/licenses/LICENSE-2.0 |
Contributor
Author
Yes, that's ok for me. |
Member
|
Thank you. Last ask, could you squash the commits into one commit please? |
…tHttpEngineBuilder43 which can cause indefinetly hangs
b57ccab to
15d26a7
Compare
Contributor
Author
Done. |
jamezp
approved these changes
Mar 19, 2025
Member
|
Thank you @beth-soptim! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…entHttpEngineBuilder43 which can cause indefinetly hangs