[RESTEASY-3553] Send connection close header when Netty http decoder fails #4407
Conversation
|
I don't know why the tests fail in windows |
|
Yeah, it seems to be related to the change. I've got a Windows VM I can do some testing on. |
The problem was related with the SocketException that is thrown when the connection is reset. |
|
Hello @txema-martinez-scopely, I'm sorry for the late review/response on this. I also truly appreciate all the work you've done on this. We require all contributions to be made under the terms of the ASL 2.0 License: http://www.apache.org/licenses/LICENSE-2.0 |
Yes, I agree to the ASL 2.0 License terms. |
jamezp
left a comment
There was a problem hiding this comment.
I'm so sorry for the delay on this. I struggled a bit to create a reproducer, but when I did this seemed to fix it and I don't really have a better idea of how to fix it. This looks reasonable to me.
There was a problem hiding this comment.
Just an FYI I'm going to add a commit after this is merged to add a copyright header here.
When the Netty
HttpObjectDecodertransitioned into aBAD_MESSAGEstate, any subsequent requests on the same connection were ignored.This PR fixes that behavior by sending a
connection: closeresponse header, so the client closes the connection.Discussion: #4351
Jira ticket: RESTEASY-3553