Fix usage of defaultProxy #4080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set this.defaultProxy before createDefaultHttpClient, cf. #6167e1534f6e2379cf0ad1074b34f87d13045e84
Contributor
Author
|
In case somebody asks: contribution intentionally submitted |
Member
|
Sorry, looks like I somehow missed this for 2 months now. While this looks reasonable to me, did you see an error because of this? |
Contributor
Author
|
Haven't see an error because proxy was no use-case for me, but setting |
jamezp
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set this.defaultProxy before createDefaultHttpClient, cf. #6167e1534f6e2379cf0ad1074b34f87d13045e84