[RESTEASY-2992] Fix the ClientConfigProviderTestJarHelper to work on Windows #3632
+26
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@jamezp I think the format check is stuck on this one. |
jamezp
requested changes
May 16, 2023
...-tests/src/test/java/org/jboss/resteasy/test/security/ClientConfigProviderTestJarHelper.java
Outdated
Show resolved
Hide resolved
...-tests/src/test/java/org/jboss/resteasy/test/security/ClientConfigProviderTestJarHelper.java
Outdated
Show resolved
Hide resolved
...-tests/src/test/java/org/jboss/resteasy/test/security/ClientConfigProviderTestJarHelper.java
Outdated
Show resolved
Hide resolved
...-tests/src/test/java/org/jboss/resteasy/test/security/ClientConfigProviderTestJarHelper.java
Outdated
Show resolved
Hide resolved
Member
Sorry @Dkafetzis, it just required an approval to run for some reason. |
a78cd80 to
6e0c79b
Compare
Author
|
@jamezp changes applied, waiting for another review |
jamezp
requested changes
May 18, 2023
Member
jamezp
left a comment
There was a problem hiding this comment.
It looks like some formatting was missed before the commit. Just make sure you compile before committing. You could just do something like the following to fix this:
mvn clean install -DskipTests
git commit -a --amend
Author
|
@jamezp I don't know why the TCK test is failing now, I also rerun the tests locally and everything is passing |
jamezp
approved these changes
May 24, 2023
Member
|
@Dkafetzis this is a known intermittent failure. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue link https://issues.redhat.com/browse/RESTEASY-2992