Skip to content

Export and import preferences#657

Merged
manojVivek merged 6 commits intoresponsively-org:masterfrom
danielm2402:feature/export-and-import-preferences
Feb 22, 2022
Merged

Export and import preferences#657
manojVivek merged 6 commits intoresponsively-org:masterfrom
danielm2402:feature/export-and-import-preferences

Conversation

@danielm2402
Copy link
Contributor

✨ Pull Request

📓 Referenced Issue

#656

ℹ️ About the PR

Added buttons to export and import user preferences. I preferred to do the download and upload of the json file from the main process, from the renderer process there is a problem with the redux extension in development mode (I think it is a better solution to do it from the main process). I would love to read the proposals to improve UX to export / import buttons and about the configuration file which is currently a JSON.

🖼️ Testing Scenarios / Screenshots

Uploading a config file with 3 custom devices and darkmode

I tested exporting and importing configurations between windows (10) and Linux (Debian bullseye)

@manojVivek
Copy link
Collaborator

@danielm2402 Thanks you so much for working on this. This looks wonderful. 🎉

Just a design suggestion, these options right now look too prominent/distracting. Shall we push it into a Kebab menu like this mockup below:
Screenshot 2022-01-17 at 7 21 42 PM 1

Link to the Kebab Menu component: https://github.com/responsively-org/responsively-app/blob/master/desktop-app/app/components/KebabMenu.js

@danielm2402
Copy link
Contributor Author

@danielm2402 Thanks you so much for working on this. This looks wonderful. 🎉

Just a design suggestion, these options right now look too prominent/distracting. Shall we push it into a Kebab menu like this mockup below:
Screenshot 2022-01-17 at 7 21 42 PM 1

Link to the Kebab Menu component: https://github.com/responsively-org/responsively-app/blob/master/desktop-app/app/components/KebabMenu.js

I really like your idea, I will make the respective changes

@manojVivek
Copy link
Collaborator

@danielm2402 Did you get a chance to look into it?

@danielm2402
Copy link
Contributor Author

@manojVivek Hello, I was away a bit due to health problems, but before the weekend I will make the menu

@manojVivek
Copy link
Collaborator

No worries @danielm2402.
Please take care of your health, this can wait for whenever you recovered and feeling good. 🙂

@danielm2402
Copy link
Contributor Author

@manojVivek Sorry for taking so long, as I mentioned I had some health problems, but, I'm back and I want to help in this amazing project. I just added the kebab menu, I am looking forward to your reviews.

@manojVivek
Copy link
Collaborator

@danielm2402 Amazing, can you please add a screenshot of how it looks?

@danielm2402
Copy link
Contributor Author

@manojVivek Of course

menukeb

@manojVivek
Copy link
Collaborator

@danielm2402 One suggestion, can you please make the options subtle like the ones in the screenshot below?

Screenshot 2022-02-16 at 2 16 54 PM

@danielm2402
Copy link
Contributor Author

@manojVivek Resolved. I remain attentive to your comments. Thank you very much

kebabitem

Copy link
Collaborator

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, merging it now.

@manojVivek manojVivek linked an issue Feb 22, 2022 that may be closed by this pull request
@manojVivek manojVivek merged commit 09cdd79 into responsively-org:master Feb 22, 2022
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export/Import config / devices list

3 participants