fix: disable fullscreen on F while typing (#1441)#1454
Merged
manojVivek merged 2 commits intoresponsively-org:mainfrom Dec 16, 2025
Merged
fix: disable fullscreen on F while typing (#1441)#1454manojVivek merged 2 commits intoresponsively-org:mainfrom
manojVivek merged 2 commits intoresponsively-org:mainfrom
Conversation
|
|
Collaborator
|
@bhnprksh222 Thanks for the contribution, the code looks good, can you please attach a screen recording showing the fix working? |
Contributor
Author
|
FYI |
Contributor
Author
|
@manojVivek Could you please refer to the uploaded video? |
manojVivek
approved these changes
Dec 16, 2025
Collaborator
manojVivek
left a comment
There was a problem hiding this comment.
Looking great, thank you so much for this contribution!
Collaborator
|
@all-contributors Please add @bhnprksh222 for code. |
Contributor
|
I've put up a pull request to add @bhnprksh222! 🎉 |
|
@bhnprksh222 This issue still persists in v1.17.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Prevent fullscreen toggle when typing in input fields
This PR resolves an issue where pressing
Fwhile typing inside an input field (input,textarea, orcontentEditable) incorrectly triggered fullscreen mode in the webview.A guard has been added to skip the fullscreen shortcut when a text-entry element is focused.
Fixes
Fixes #1441
Summary of Changes
isUserTyping()check inpreload-webview.ts