fix: Fix restricted device size to enable phones landscape#1340
Merged
violetadev merged 1 commit intoresponsively-org:mainfrom Dec 14, 2024
Merged
Conversation
Contributor
|
awesome work, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
📓 Referenced Issue
Fix #1210
ℹ️ About the PR
Added checker for landscape mode before strict ("w-52") size of device.
flex-shrink-0 is not needed because we have control over elements with overflow scroll.
But long-term I'd put all the layout settings (incl. Masonry Layout, Preview Layout) into one component. Now it's too easy to break the whole visual configuration with inappropriate css style
🖼️ Testing Scenarios / Screenshots