Some new devices added to devicelist.ts#1293
Some new devices added to devicelist.ts#1293manojVivek merged 2 commits intoresponsively-org:mainfrom
Conversation
|
web_dev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| isMobileCapable: false, | ||
| }, | ||
| { | ||
| id: '90004', |
There was a problem hiding this comment.
Can you please fix the IDs to stick to the guidelines here: https://github.com/responsively-org/responsively-app/pull/1293/files#diff-1f757e572fe35320119d79efc7411be133df8ec132a1737e78a872eaa1720da8R16-R22
desktop-app/src/common/deviceList.ts
Outdated
| type: 'phone', | ||
| isTouchCapable: true, | ||
| isMobileCapable: true, | ||
| }, |
There was a problem hiding this comment.
It would be great if you could run the prettier formatting on this file.
There was a problem hiding this comment.
fixed id and added prettier
manojVivek
left a comment
There was a problem hiding this comment.
Looks good, thank you for your contribution!
|
@all-contributors Please add @Sukrit-Prakash for code. |
|
I've put up a pull request to add @Sukrit-Prakash! 🎉 |
✨ Pull Request
ℹ️ About the PR
This PR introduces the following updates to the devicelist.ts:
1.Added support for Galaxy Z Fold 5 with a screen size of 344x882, dpr: 1.
2.Added support for Asus Zenbook Fold with a screen size of 853x1280, dpr: 2.
3.Added support for Pixel 7 with a screen size of 412x915, dpr: 2.625.
Each device entry includes its specific properties like userAgent, capabilities, and device type (phone, tablet).
🖼️ Testing Scenarios / Screenshots
Tested the changes by simulating these devices in the responsive design mode of Google Chrome DevTools.
Verified touch and mobile capabilities for the Galaxy Z Fold 5 and Pixel 7.
Ensured that the Asus Zenbook Fold is categorized as a tablet with the appropriate touch capabilities.