fix: show ctrl as mod button in shortcut modal for windows devices#1187
Merged
manojVivek merged 2 commits intoresponsively-org:mainfrom Jan 22, 2024
Merged
fix: show ctrl as mod button in shortcut modal for windows devices#1187manojVivek merged 2 commits intoresponsively-org:mainfrom
manojVivek merged 2 commits intoresponsively-org:mainfrom
Conversation
|
|
manojVivek
approved these changes
Jan 22, 2024
Collaborator
manojVivek
left a comment
There was a problem hiding this comment.
Thank you so much for taking care of this so quickly! 🚀
Collaborator
|
@all-contributors Please add @surajbobade for code. |
Contributor
|
I've put up a pull request to add @surajbobade! 🎉 |
Contributor
Author
Most welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
📓 Referenced Issue
Fixes: #1185
ℹ️ About the PR
Currently for all the platform, shortcut mod is key visible as '⌘'. It should be Ctrl for windows devices.
🖼️ Testing Scenarios / Screenshots