Merged
Conversation
Adds rules/guides package
manojVivek
requested changes
Nov 25, 2023
Collaborator
manojVivek
left a comment
There was a problem hiding this comment.
This is such an essential utility and great work implementing it. 🚀
Did review the code and also a round of testing and added the observations as comments on the code.
desktop-app/src/renderer/components/Previewer/Device/Toolbar.tsx
Outdated
Show resolved
Hide resolved
- default empty array - remove default padding - align left px value ofr rulers - updated keyboard shortcut
missing overflow
|
Is this feature usable? |
Collaborator
|
It is not live yet, waiting on a related bug to be addressed. It should be out in a week or so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
📓 Referenced Issue
#1149 Adds persistent guides and rulers
ℹ️ About the PR
🖼️ Testing Scenarios / Screenshots