Merged
Conversation
manojVivek
reviewed
Nov 8, 2023
Collaborator
manojVivek
left a comment
There was a problem hiding this comment.
Sorry for the delay in reviewing this, but this is fantastic! 🔥
Just a minor comment on the UX and some tweaks for the drop down would make it ready for a release. These UX things, I can take care of if you don't mind.
Collaborator
|
@astuanax I have some commits (improvements we discussed) made on top of this PR, but I'm unable to push those to your branch (permission issues?). So, I'll merge this PR and then raise a new PR with my branch. |
manojVivek
reviewed
Nov 14, 2023
Collaborator
manojVivek
left a comment
There was a problem hiding this comment.
@astuanax Thank you so much for contributing this! Looking forward to more! 🎉
Collaborator
|
@all-contributors Please add @astuanax for code. |
Contributor
|
I've put up a pull request to add @astuanax! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
📓 Referenced Issue
#1075 Accessibility simulator menu
ℹ️ About the PR
This PR adds a menu, dropdown, to apply XSLT filters to one of the webviews to simulate the experience of people with visual impairments and color deficiencies.
Things to consider:
🖼️ Testing Scenarios / Screenshots
The menu can be applied to any websites.
Here is a video on how to test:
Peek.2023-10-27.18-58.mp4