chore: stop running react-email binary test on every dep bump#307
Merged
Conversation
gabrielmfern
approved these changes
May 21, 2026
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Auto-approved: This CI configuration change only removes two paths from the workflow trigger filter to avoid unnecessary binary tests on dependency bumps, which is a low-risk, isolated change that does not affect business logic or production infrastructure.
Re-trigger cubic
dielduarte
approved these changes
May 21, 2026
The path filter included package.json and pnpm-lock.yaml, so every Renovate PR triggered the full macOS/Linux/Windows binary build and react-email bundling check. Drop those paths; rely on workflow_dispatch for ad-hoc runs when an esbuild or @yao-pkg/pkg bump warrants it.
ce405f3 to
f1a65f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path filter included package.json and pnpm-lock.yaml, so every Renovate PR triggered the full macOS/Linux/Windows binary build and react-email bundling check. Drop those paths; rely on workflow_dispatch for ad-hoc runs when an esbuild or @yao-pkg/pkg bump warrants it.
Summary by cubic
Stop running the react-email binary test on every dependency bump by removing
package.jsonandpnpm-lock.yamlfrom the workflow path filter. The CI job now runs only on relevant source/workflow changes; trigger ad‑hoc viaworkflow_dispatchwhen bumpingesbuildor@yao-pkg/pkg.Written for commit f1a65f4. Summary will update on new commits. Review in cubic