Skip to content

Replace our ArrowBuffer with arrow's ScalarBuffer#9732

Merged
emilk merged 8 commits intomainfrom
emilk/remove-arrow-buffer
Apr 14, 2025
Merged

Replace our ArrowBuffer with arrow's ScalarBuffer#9732
emilk merged 8 commits intomainfrom
emilk/remove-arrow-buffer

Conversation

@emilk
Copy link
Copy Markdown
Member

@emilk emilk commented Apr 14, 2025

@emilk emilk added 🏹 arrow Apache Arrow 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Apr 14, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
85df9de https://rerun.io/viewer/pr/9732 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk marked this pull request as ready for review April 14, 2025 11:28
@emilk
Copy link
Copy Markdown
Member Author

emilk commented Apr 14, 2025

@rerun-bot full-check

@github-actions
Copy link
Copy Markdown
Contributor

Started a full build: https://github.com/rerun-io/rerun/actions/runs/14444511245

@emilk emilk changed the title Make ArrowBuffer deref to ScalarBuffer Replace our ArrowBuffer with arrow's ScalarBuffer Apr 14, 2025
Base automatically changed from emilk/fix-remaining-arrow2-stuff to main April 14, 2025 11:58
@emilk emilk force-pushed the emilk/remove-arrow-buffer branch from 163f962 to 85df9de Compare April 14, 2025 11:59
@emilk emilk merged commit db9c510 into main Apr 14, 2025
36 of 38 checks passed
@emilk emilk deleted the emilk/remove-arrow-buffer branch April 14, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏹 arrow Apache Arrow exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove re_types_core::ArrowBuffer

1 participant