Adding DefaultCamera to Spatial3D view#8211
Conversation
|
This PR needs to be rebased against the current main branch. Please let me know what you mean about the overall shape of the changes. If they are good, I will rebase against main. |
Wumpf
left a comment
There was a problem hiding this comment.
at first I though it's an odd starting place to set the default camera given that the camera itself isn't specified yet
But I realize that this is the easiest entry point into being able to set the camera without having to worry about blueprint update frequency and the various other properties, so great initiative!
The implementation is off the mark however:
- properties should be exposed in the ui, that isn't wired up here
- there should be default provider implementations for these components now that do what
default_eyedid before.default_eyethen should always go to the components which may in turn be routed to the default providers
-> this framework ensures that the assumed state of the property is transparent for the rest of the viewer (i.e. just the selection panel today)
I have a bit of time this week for smaller tasks like this, if you want I can take it from here
idea for a follow-up PR: extend the ui with a "set current" button that allows setting the default to the current camera pose. that way one can always return to it with double click on the viewer \o/
| namespace rerun.blueprint.archetypes; | ||
|
|
||
|
|
||
| /// Defines a default camera view. |
There was a problem hiding this comment.
should explain more what this is: When is the default camera set, what happens when there is none.
| /// Origin of the camera view. | ||
| origin: rerun.blueprint.components.CameraOrigin ("attr.rerun.component_optional", nullable, order: 1100); | ||
|
|
||
| /// Target of the camera view. | ||
| target: rerun.blueprint.components.CameraTarget ("attr.rerun.component_optional", nullable, order: 1200); |
There was a problem hiding this comment.
should describe what happens if only one of those is set each
| "attr.docs.category": "Spatial 3D", | ||
| "attr.docs.view_types": "Spatial3DView, Spatial2DView: if logged above active projection", |
There was a problem hiding this comment.
| "attr.docs.category": "Spatial 3D", | |
| "attr.docs.view_types": "Spatial3DView, Spatial2DView: if logged above active projection", |
We don't use those on property archetypes so far. (also the 2D space view part is obv. wrong)
| /// If a timeline is specified more than once, the first entry will be used. | ||
| time_ranges: rerun.blueprint.archetypes.VisibleTimeRanges (order: 10000); | ||
|
|
||
| /// Configures the default camera position of the 3D view. |
There was a problem hiding this comment.
similar as above, should clarify a little bit more what that means
| 1. - (1. - t) * (1. - t) | ||
| } | ||
|
|
||
| fn vec3(v: Vec3D) -> Vec3 { |
There was a problem hiding this comment.
does into not work on those? thought that was implemented
Also, adding an unnamespaced vec3 function makes me a bit uneasy - glam and egui already have those as well
There was a problem hiding this comment.
I am pretty new to Rust, so not sure what you mean by into to be honest :/
| pub struct View3DState { | ||
| pub view_eye: Option<ViewEye>, | ||
|
|
||
| pub view_eye_default: Option<ViewEye>, |
| if let Ok(Some(pos_origin)) = default_camera.component_or_empty::<CameraOrigin>() { | ||
| if let Ok(Some(pos_target)) = default_camera.component_or_empty::<CameraTarget>() { | ||
| if self.view_eye_default.is_none() { | ||
| // Facking last eye interaction. Otherwise the next `if` | ||
| // statement in this function causes the camera to change | ||
| // if there is a change to the bounding box (e.g. when new | ||
| // objects are added to the scene.) | ||
| self.last_eye_interaction = Some(Instant::now()); | ||
|
|
||
| self.view_eye_default = Some(from_to_eye( | ||
| vec3(pos_origin.0), | ||
| vec3(pos_target.0), | ||
| scene_view_coordinates, | ||
| )); | ||
|
|
||
| self.view_eye = self.view_eye_default; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't quite follow why this is needed.
Shouldn't the behavior of default_eye be adjusted instead?
There was a problem hiding this comment.
When double clicking on the 3D view, I want the camera to jump back to the default camera settings, if specified. The double click calls the View3DState::reset_camera method. While the default camera property is available from the gui-rendering path (default_camera.component_or_empty::<CameraOrigin>() etc), it is not so easy to query it from the reset_camera method. As such, I added a new field view_eye_default on the View3DState, which is set the first time the gui renders. This field is then accessible from the View3DState::reset_camera method.
I know this is not great and it would be cleaner to query to store for the CameraOrigin etc component directly, but I was not sure how to do that easily. So I decided to go for this workaround.
|
|
||
|
|
||
| /// Defines a default camera view. | ||
| table DefaultCamera ( |
There was a problem hiding this comment.
Maybe more like
| table DefaultCamera ( | |
| table DefaultEyeCameraPose ( |
The problem with camera is that...
- it gets confused with logged pinhole cameras a lot which is why we just call it
eyein the implementationeyealone though is probably even more confusing
- this is not a full camera specification but just where it is. Later we'll have to add more things like camera controls (orbit vs ego vs future stuff) etc. which is then the "full specification" which will have a lot more fields
|
@Wumpf thank you for taking a look at this PR and your comments. I agree with all your comments. I left a comment on why I've introduced the If you manage to do so, I would appreciate if you can finish this up. |
|
putting this on draft for now until I resurrect it (hopefully later this week, maybe early next) |
|
Obsolete now - camera in 0.27 is fully configurable by blueprint |
At the moment it is not possible to set the camera position and view in the Spatial3D view. This PR implements this.