Skip to content

Require nasm for AV1 decoding, unless on arm64 macOS#7742

Merged
emilk merged 6 commits intomainfrom
emilk/nasm-flag
Oct 15, 2024
Merged

Require nasm for AV1 decoding, unless on arm64 macOS#7742
emilk merged 6 commits intomainfrom
emilk/nasm-flag

Conversation

@emilk
Copy link
Copy Markdown
Member

@emilk emilk commented Oct 15, 2024 •
edited
Loading

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md feat-video anything video decoding, player, querying, data modelling of videos etc. labels Oct 15, 2024
@emilk emilk added this to the 0.19 - Dataframe and video milestone Oct 15, 2024
@emilk
Copy link
Copy Markdown
Member Author

emilk commented Oct 15, 2024

@rerun-bot full-check

@emilk emilk marked this pull request as draft October 15, 2024 13:57
@emilk
Copy link
Copy Markdown
Member Author

emilk commented Oct 15, 2024

@rerun-bot full-check

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 15, 2024 •
edited by emilk
Loading

✅ Started a full build: https://github.com/rerun-io/rerun/actions/runs/11347670672

emilk
emilk commented Oct 15, 2024
View reviewed changes
crates/store/re_video/src/lib.rs
Comment on lines +16 to +18
/// Which features was this crate compiled with?
pub fn features() -> Vec<&'static str> {
// TODO(emilk): is there a helper crate for this?
Copy link
Copy Markdown
Member Author

@emilk emilk Oct 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to do something smarter in a follow-up PR

@emilk emilk marked this pull request as ready for review October 15, 2024 14:24
@emilk emilk merged commit 6fb673b into main Oct 15, 2024
@emilk emilk deleted the emilk/nasm-flag branch October 15, 2024 14:58
@traversaro traversaro mentioned this pull request Oct 19, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md feat-video anything video decoding, player, querying, data modelling of videos etc.

Projects

None yet

Milestone

0.19 - Dataframe and video

Development

Successfully merging this pull request may close these issues.

Can't use nasm feature on arch linux (for faster rav1d video decoding) Make sure we compile the binaries we upload to GitHub with -F nasm

1 participant

@emilk