Arrow Tensor logging with Image display#714
Merged
Conversation
jleibs
suggested changes
Jan 10, 2023
crates/re_viewer/src/ui/view_spatial/scene/scene_part/images.rs
Outdated
Show resolved
Hide resolved
| #[derive(Debug, ArrowField, ArrowSerialize, ArrowDeserialize)] | ||
| #[arrow_field(type = "dense")] | ||
| pub enum TensorData { | ||
| U8(Vec<u8>), |
Contributor
There was a problem hiding this comment.
Using a Vec here makes sense for the short-term so you don't have to jump through as many serializer hoops, but we definitely want a TODO here to just hang onto the underlying arrow2::Buffer<T> directly. That way we can refer to the same Arc'd data from the store and should be able to do this mostly zero-copy.
jleibs
reviewed
Jan 10, 2023
10 tasks
jleibs
reviewed
Jan 12, 2023
3 tasks
jleibs
approved these changes
Jan 12, 2023
Contributor
jleibs
left a comment
There was a problem hiding this comment.
That one was a bit of a slog. Nice work!
Comment on lines
32
to
+33
| pub fn as_ndarray<A: bytemuck::Pod + TensorDataTypeTrait>( | ||
| tensor: &Tensor, | ||
| tensor: &ClassicTensor, |
Contributor
There was a problem hiding this comment.
TODO: Make this work with TensorTrait?
Contributor
Author
There was a problem hiding this comment.
The new Tensor already provides to/from conversions for ndarray
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)Partially closes #517, #522