Skip to content

Rename ImageEncoded to EncodedImage#7087

Merged
emilk merged 2 commits intomainfrom
emilk/encoded-image
Aug 7, 2024
Merged

Rename ImageEncoded to EncodedImage#7087
emilk merged 2 commits intomainfrom
emilk/encoded-image

Conversation

@emilk
Copy link
Copy Markdown
Member

@emilk emilk commented Aug 7, 2024

What

This is a better name (rolls off the tongue better).

It also removed a name clash, allowing us to later:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md 🪵 Log & send APIs Affects the user-facing API for all languages labels Aug 7, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 7, 2024

Deployed docs

Commit Link
477db94 https://landing-k7sppu5g4-rerun.vercel.app/docs

@emilk emilk mentioned this pull request Aug 7, 2024
12 tasks
@Wumpf Wumpf self-requested a review August 7, 2024 08:13
Copy link
Copy Markdown
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't do enough renaming 😅

@emilk emilk merged commit 0cc3908 into main Aug 7, 2024
@emilk emilk deleted the emilk/encoded-image branch August 7, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude from changelog PRs with this won't show up in CHANGELOG.md 🪵 Log & send APIs Affects the user-facing API for all languages 🚜 refactor Change the code, not the functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants