Skip to content

Fix enum-related issues from #7045#7078

Merged
jleibs merged 9 commits intomainfrom
jleibs/enum_bad_merge
Aug 6, 2024
Merged

Fix enum-related issues from #7045#7078
jleibs merged 9 commits intomainfrom
jleibs/enum_bad_merge

Conversation

@jleibs
Copy link
Copy Markdown
Contributor

@jleibs jleibs commented Aug 6, 2024

What

Mis-merged before pushing all fixes.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs marked this pull request as ready for review August 6, 2024 15:09
@jleibs jleibs added codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md labels Aug 6, 2024
@jleibs jleibs merged commit 8bca74b into main Aug 6, 2024
@jleibs jleibs deleted the jleibs/enum_bad_merge branch August 6, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant