Skip to content

Remove legacy query engine and promises#7033

Merged
teh-cmc merged 5 commits intomainfrom
cmc/chunkified_queries_final
Aug 2, 2024
Merged

Remove legacy query engine and promises#7033
teh-cmc merged 5 commits intomainfrom
cmc/chunkified_queries_final

Conversation

@teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Aug 1, 2024 •
edited by github-actions bot
Loading

Everything has been chunkified. Remove re_query, remove promises.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 🔍 re_query affects re_query itself do-not-merge Do not merge this PR 🚜 refactor Change the code, not the functionality include in changelog labels Aug 1, 2024
@teh-cmc
Copy link
Member Author

teh-cmc commented Aug 1, 2024

@rerun-bot full-check

@github-actions
Copy link

github-actions bot commented Aug 1, 2024

Started a full build: https://github.com/rerun-io/rerun/actions/runs/10195779666

Wumpf
Wumpf approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what a time to be alive!

@teh-cmc teh-cmc force-pushed the cmc/chunkified_queries_17_everything_else branch from 3b84331 to 3298ae1 Compare August 2, 2024 10:08
Base automatically changed from cmc/chunkified_queries_17_everything_else to main August 2, 2024 10:09
@teh-cmc teh-cmc force-pushed the cmc/chunkified_queries_final branch from 307dde2 to c273c98 Compare August 2, 2024 10:16
@teh-cmc
Copy link
Member Author

teh-cmc commented Aug 2, 2024

@rerun-bot full-check

@github-actions
Copy link

github-actions bot commented Aug 2, 2024

Started a full build: https://github.com/rerun-io/rerun/actions/runs/10213942486

@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Aug 2, 2024
@teh-cmc teh-cmc merged commit 4d61b04 into main Aug 2, 2024
@teh-cmc teh-cmc deleted the cmc/chunkified_queries_final branch August 2, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees

No one assigned

Labels

include in changelog 🔍 re_query affects re_query itself 🚜 refactor Change the code, not the functionality

Projects

None yet

Milestone

No milestone

2 participants

@teh-cmc @Wumpf