Port SegmentationImage to the new image archetype style#6928
Merged
Conversation
Contributor
Deployed docs
|
Wumpf
approved these changes
Jul 17, 2024
| return Err(ImageConstructionError::BadImageShape(tensor_data.shape)); | ||
| } | ||
|
|
||
| let (blob, data_type) = match tensor_data.buffer { |
Member
There was a problem hiding this comment.
maybe now is the time to add a conversion function that is shared between segmentation_image_ext and depth_image_ext?
| reinterpret_cast<const uint8_t*>(pixels), resolution_, get_data_type(pixels)} {} | ||
|
|
||
| /// New segmentation image from tensor data. | ||
| /// Row-major. |
Member
There was a problem hiding this comment.
these are pretty sporadic, would be nice to write something nicer imho. Same on DepthImage, but didn't pay enough attention last time.
- what is row major?
- what does "borrows" mean? That's not a common concept in C++ and the implication (crashes at random) needs to be clarified
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DepthImagearchetype #6915Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.