Skip to content

Fix rerun-web canvas size#6511

Merged
jprochazk merged 1 commit intomainfrom
jan/fix-web-viewer-size
Jun 6, 2024
Merged

Fix rerun-web canvas size#6511
jprochazk merged 1 commit intomainfrom
jan/fix-web-viewer-size

Conversation

@jprochazk
Copy link
Copy Markdown
Member

@jprochazk jprochazk commented Jun 6, 2024 •
edited by github-actions bot
Loading

What

The canvas size was the default of 300x150 because we didn't update the CSS in index.html after

Closes

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jprochazk jprochazk added 🕸️ web regarding running the viewer in a browser include in changelog labels Jun 6, 2024
jleibs
jleibs approved these changes Jun 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much simpler. However, I don't have any context on the historical reasons for the previous complexity, which always makes me a bit nervous.

@emilk
Copy link
Copy Markdown
Member

emilk commented Jun 6, 2024 •
edited
Loading

I don't have any context on the historical reasons for the previous complexity, which always makes me a bit nervous.

Context: the old CSS was me copy-pasting things that I don't understand

@jprochazk jprochazk merged commit 4470162 into main Jun 6, 2024
@jprochazk jprochazk deleted the jan/fix-web-viewer-size branch June 6, 2024 12:13
@jprochazk
Copy link
Copy Markdown
Member Author

jprochazk commented Jun 6, 2024

However, I don't have any context on the historical reasons for the previous complexity, which always makes me a bit nervous.

I believe the original CSS here was taken from the egui demo app, or its predecessor. All it did was move the canvas into place, and then some code in eframe took care of resizing the canvas to the equivalent of width: 100%; height: 100%. That code in eframe is gone now, so that the size of the canvas can be controlled fully through CSS like is being done in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jleibs jleibs jleibs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

include in changelog 🕸️ web regarding running the viewer in a browser

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jprochazk @emilk @jleibs