re_datastore: sanity checking cluster keys and their data#650
Merged
re_datastore: sanity checking cluster keys and their data#650
Conversation
teh-cmc
commented
Dec 27, 2022
crates/re_arrow_store/src/store.rs
Outdated
Comment on lines
+499
to
+500
| #[cfg(debug_assertions)] | ||
| cluster_key: _, |
jleibs
approved these changes
Dec 31, 2022
| /// Carrying the cluster key around in debug builds to help with assertions and sanity checks | ||
| /// all over the place. | ||
| #[cfg(debug_assertions)] | ||
| pub(crate) cluster_key: ComponentName, |
Contributor
There was a problem hiding this comment.
There was at least once place in the upstream-PR where IndexBuckets knowing the cluster_key would be helpful -- maybe this doesn't need to be debug-gated?
Contributor
Author
There was a problem hiding this comment.
It turned out not be useful in that other PR after all... then again, now that ComponentNames are actually interned under the hood, there's really not that much reason not to store them in each and every bucket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #648
Requires #609 (to keep things linear, don't want to have to deal with a multiverse situation...)