Skip to content

Move {Viewport, SpaceView, Container}Blueprint to new re_viewport_blueprint crate#6405

Merged
abey79 merged 10 commits intomainfrom
antoine/viewport-blueprint-refactor
May 23, 2024
Merged

Move {Viewport, SpaceView, Container}Blueprint to new re_viewport_blueprint crate#6405
abey79 merged 10 commits intomainfrom
antoine/viewport-blueprint-refactor

Conversation

@abey79
Copy link
Copy Markdown
Member

@abey79 abey79 commented May 22, 2024

What

This enable more general access to manipulating the blueprint and unlock further crate splitting.

TODO

  • delete the traits in data_query.rs and use concrete types instead
  • move the UI function introduced by Andreas back to re_space_view

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 22, 2024
@abey79 abey79 changed the title Moved SpaceViewBlueprint (and friend) to new re_viewport_blueprint Move {Viewport, SpaceView, Container}Blueprint to new re_viewport_blueprint crate May 22, 2024
@abey79 abey79 force-pushed the antoine/viewport-blueprint-refactor branch from 3253b36 to 6515273 Compare May 22, 2024 19:59
@abey79 abey79 marked this pull request as ready for review May 23, 2024 09:03
@Wumpf Wumpf self-requested a review May 23, 2024 10:21
@abey79 abey79 merged commit be84090 into main May 23, 2024
@abey79 abey79 deleted the antoine/viewport-blueprint-refactor branch May 23, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split ViewportBlueprint in its own crate

2 participants