Conversation
0d4b52f to
8e7c6f3
Compare
thread_local_stream leaking contextbbd4043 to
5977f52
Compare
5977f52 to
935f63c
Compare
abey79
approved these changes
May 7, 2024
Member
abey79
left a comment
There was a problem hiding this comment.
Great stuff! Extensively discussed in a huddle. TLDR: some more comments welcome and the __enter__ call in the finally clause of recording_stream_generator_ctx needs revisiting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In
thread_local_stream, don't yield while holding the stream context open. Re-create context before continuing the generator.Also introduce a new
recording_stream_generator_ctxfor more advanced usage. This is mainly an escape hatch.The problem from the example can now be handled using:
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.