Skip to content

Folder structure for code snippets#6219

Merged
jleibs merged 23 commits intomainfrom
andreas/reorganize-snippets
May 9, 2024
Merged

Folder structure for code snippets#6219
jleibs merged 23 commits intomainfrom
andreas/reorganize-snippets

Conversation

@Wumpf
Copy link
Copy Markdown
Member

@Wumpf Wumpf commented May 3, 2024 •
edited by github-actions bot
Loading

What

(either someone fell victim to a github glitch, or really liked creating issues about this 😄)

The compare snippet script needed quite a bit of love to make this work.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 3, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 3, 2024 •
edited
Loading

Deployed docs

Commit Link
9f27466 https://landing-l0m21n6s9-rerun.vercel.app/docs

@Wumpf Wumpf marked this pull request as draft May 3, 2024 16:17
@Wumpf
Copy link
Copy Markdown
Member Author

Wumpf commented May 3, 2024

lots of things failing, including webpage build

@Wumpf Wumpf force-pushed the andreas/reorganize-snippets branch from 5abffed to f5ad582 Compare May 8, 2024 16:43
@Wumpf Wumpf marked this pull request as ready for review May 8, 2024 16:43
@Wumpf
Copy link
Copy Markdown
Member Author

Wumpf commented May 8, 2024

@rerun-bot full-check

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 8, 2024

Started a full build: https://github.com/rerun-io/rerun/actions/runs/9005576258

jleibs
jleibs reviewed May 8, 2024
View reviewed changes
crates/re_viewer/data/quick_start_guides/quick_start_spawn.cpp
Copy link
Copy Markdown
Contributor

@jleibs jleibs May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this used to be a symlink which means it was linking to a thing that was threotically being round-trip-tested. I'm not seeing a mechanism that causes that to be the case now.

Copy link
Copy Markdown
Contributor

@jleibs jleibs May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, does anything even use this anymore? Didn't we get rid of embedded quick starts in the viewer?

@Wumpf Wumpf requested a review from jleibs May 8, 2024 19:57
@Wumpf
Copy link
Copy Markdown
Member Author

Wumpf commented May 8, 2024

had to do some bigger changes: the toml wasn't valid for pixi run -e wheel-test build-examples snippets example_data/snippets, see https://github.com/rerun-io/rerun/actions/runs/9005576258/job/24741561218
Turned around a bit and removed support for magic "example" named files and support arbitrary subdirs more consistently for the most part. But didn't get things to pass all tests locally on windows. Direction should be correct

@Wumpf
Copy link
Copy Markdown
Member Author

Wumpf commented May 8, 2024

It really looks like crates/re_viewer/data/quick_start_guides should be removed

@Wumpf Wumpf added the do-not-merge Do not merge this PR label May 8, 2024
@Wumpf
Copy link
Copy Markdown
Member Author

Wumpf commented May 9, 2024

(do not merge until main ci is green with this)

@jleibs
Copy link
Copy Markdown
Contributor

jleibs commented May 9, 2024

@rerun-bot full-check

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 9, 2024

Started a full build: https://github.com/rerun-io/rerun/actions/runs/9019277110

@jleibs jleibs removed the do-not-merge Do not merge this PR label May 9, 2024
@jleibs
Copy link
Copy Markdown
Contributor

jleibs commented May 9, 2024

@rerun-bot full-check

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 9, 2024

Started a full build: https://github.com/rerun-io/rerun/actions/runs/9019636152

@jleibs jleibs merged commit 0f34aaa into main May 9, 2024
@jleibs jleibs deleted the andreas/reorganize-snippets branch May 9, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jleibs jleibs Awaiting requested review from jleibs

Assignees

No one assigned

Labels

🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add folder structure to snippets Add organizational folders to snippets Add organizational folders to snippets

2 participants

@Wumpf @jleibs