Conversation
|
the default bounds isn't dealing correctly with principal point yet: notice there's a black bar at the bottom - this is before doing any panning/zooming etc., freshly reset |
Wumpf
left a comment
There was a problem hiding this comment.
ah didn't notice this got drafted and started a review. Didn't come all that far yet :)
Co-authored-by: Andreas Reich <andreas@rerun.io>
|
I re-drafted it once you started finding bugs |
5222453 to
bdf6843
Compare
|
I think I fixed it now, but will add a test tomorrow, and add some comments for future improvements |
89d594f to
60aea9d
Compare
Wumpf
left a comment
There was a problem hiding this comment.
a few more things to clean up but then we're good to go!
Very happy to finally get this in, this gets is a much better position to do further improvements in 2D land
| [dependencies] | ||
| re_log = { workspace = true, features = ["setup"] } | ||
| rerun = { path = "../../../crates/rerun", features = ["web_viewer"] } | ||
| rerun = { path = "../../../crates/rerun", features = ["clap", "web_viewer"] } |
There was a problem hiding this comment.
not seeing any corresponding code changes, was it broken somehow?
There was a problem hiding this comment.
Yes, running this test standalone did not compile.
scripts/ci/rust_checks.py doesn't cover tests/rust, just examples/rust
| # Intentionally off-center to demonstrate that we support it | ||
| principal_point=[0.45 * img_depth.shape[1], 0.55 * img_depth.shape[0]], |
There was a problem hiding this comment.
trying to process whether this makes e.g. length of depth rays incorrect for the data at hand 🤔
There was a problem hiding this comment.
We don't know the true pinhole for the dataset, anything we use is a guess
What
By default the bounds are centered:
Before:
After:
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.