Skip to content

Add lint against linking into main branch on GitHub#6078

Merged
emilk merged 4 commits intomainfrom
emilk/main-links
Apr 23, 2024
Merged

Add lint against linking into main branch on GitHub#6078
emilk merged 4 commits intomainfrom
emilk/main-links

Conversation

@emilk
Copy link
Copy Markdown
Member

@emilk emilk commented Apr 23, 2024

What

While investigating recently broken links (because of #5966 (comment)) I decided to add a lint against linking to stuff on changing branches (e.g. /blobs/main).

Unfortunately I cannot cover it all (see #6077 for more), but this is an OK start.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 📖 documentation Improvements or additions to documentation 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Apr 23, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 23, 2024

Deployed docs

Commit Link
9e181ac https://landing-p434j5szz-rerun.vercel.app/docs

@emilk emilk force-pushed the emilk/main-links branch from 87012cb to 4e3476b Compare April 23, 2024 07:43
@Wumpf Wumpf self-requested a review April 23, 2024 07:56
Copy link
Copy Markdown
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@emilk emilk merged commit 711c3aa into main Apr 23, 2024
@emilk emilk deleted the emilk/main-links branch April 23, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧑‍💻 dev experience developer experience (excluding CI) 📖 documentation Improvements or additions to documentation exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants