Skip to content

Use new Mediapipe API in human pose tracking example#5903

Merged
roym899 merged 9 commits intomainfrom
leo/fix-pose-tracking-mediapipe
Apr 11, 2024
Merged

Use new Mediapipe API in human pose tracking example#5903
roym899 merged 9 commits intomainfrom
leo/fix-pose-tracking-mediapipe

Conversation

@roym899
Copy link
Copy Markdown
Contributor

@roym899 roym899 commented Apr 10, 2024 •
edited by github-actions bot
Loading

What

Closes #5859.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@roym899 roym899 added examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md labels Apr 10, 2024
@roym899 roym899 requested a review from abey79 April 10, 2024 18:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2024 •
edited
Loading

Deployed docs

Commit Link
c7424c9 https://landing-1qiaba394-rerun.vercel.app/docs

@roym899 roym899 changed the title Use new mediapipe API in human pose tracking example Use new Mediapipe API in human pose tracking example Apr 10, 2024
emilk
emilk approved these changes Apr 11, 2024
View reviewed changes
examples/python/human_pose_tracking/requirements.txt Outdated
# no 3.12 version yet (https://pypi.org/project/mediapipe/)
# 0.10.10 no longer supports the legacy Pose model: https://github.com/rerun-io/rerun/issues/5859
mediapipe==0.10.9 ; python_version <= '3.11'
mediapipe>=0.10.0 ; python_version <= '3.11'
Copy link
Copy Markdown
Member

@emilk emilk Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test it with 0.10.0 as well, or should this maybe be

Suggested change
mediapipe>=0.10.0 ; python_version <= '3.11'
mediapipe>=0.10.11 ; python_version <= '3.11'

Copy link
Copy Markdown
Member

@abey79 abey79 Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd bump it to 0.10.11 yeah. Also, please make the same change in all media pipe examples (top of my head: gesture_recognition and face_detection, but you may have to run a global search).

Copy link
Copy Markdown
Contributor Author

@roym899 roym899 Apr 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with 0.10.0, it's the first version that works. Should we still bump it or try to find the first working version for the other examples also?

Copy link
Copy Markdown
Member

@abey79 abey79 Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont have a strong feeling about, but I know is that 0.10.11 worked for the other example (it was set to that before I pined them to 0.10.9 because of this example). I'd say for an example, if a given recent version is known to work, and is compatible with our range of python version (3.8 -> 3.12), it's not a bad thing to pin. (The situation would be different for a lib, ofc.)

Copy link
Copy Markdown
Contributor Author

@roym899 roym899 Apr 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I have pinned and tested all of them with 0.10.11 now.

abey79
abey79 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍🏻

examples/python/human_pose_tracking/requirements.txt Outdated
# no 3.12 version yet (https://pypi.org/project/mediapipe/)
# 0.10.10 no longer supports the legacy Pose model: https://github.com/rerun-io/rerun/issues/5859
mediapipe==0.10.9 ; python_version <= '3.11'
mediapipe>=0.10.0 ; python_version <= '3.11'
Copy link
Copy Markdown
Member

@abey79 abey79 Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd bump it to 0.10.11 yeah. Also, please make the same change in all media pipe examples (top of my head: gesture_recognition and face_detection, but you may have to run a global search).

@roym899 roym899 merged commit a8cf9ec into main Apr 11, 2024
@roym899 roym899 deleted the leo/fix-pose-tracking-mediapipe branch April 11, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abey79 abey79 abey79 approved these changes

@emilk emilk emilk approved these changes

Assignees

No one assigned

Labels

examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Human Pose Tracking example to latest Mediapipe model

3 participants

@roym899 @emilk @abey79