Show visible time range on all entities of a space view that supports it#5564
Merged
Show visible time range on all entities of a space view that supports it#5564
Conversation
jleibs
approved these changes
Mar 18, 2024
Contributor
jleibs
left a comment
There was a problem hiding this comment.
This makes sense for expediency right now but generally we need to figure out how to scale the control which UI elements are displayed in the selection panel.
Member
Author
|
agreed! |
601ef1a to
a419df1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Another fallout of group removal: Previously, you could always change the Visible Time Range on groups, since there's no groups anymore we have to show the ui on all entities.
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io